From e09957a47da9425cc26d1b33cb4e9cc3e92e9ac7 Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Tue, 12 Mar 2013 12:43:14 +0100 Subject: [PATCH] label: refactor code If text didn't change, don't change it. And if that sentence made no sense, that might explain why I refactored. --- gtk/gtklabel.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c index bc17554a23..0eac38ddaf 100644 --- a/gtk/gtklabel.c +++ b/gtk/gtklabel.c @@ -1980,15 +1980,14 @@ gtk_label_set_text_internal (GtkLabel *label, gchar *str) { GtkLabelPrivate *priv = label->priv; - gboolean text_changed; - text_changed = g_strcmp0 (priv->text, str) != 0; + if (g_strcmp0 (priv->text, str) == 0) + return; g_free (priv->text); priv->text = str; - if (text_changed) - gtk_label_select_region_index (label, 0, 0); + gtk_label_select_region_index (label, 0, 0); } static void -- 2.30.2